-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove legacy appmodule boiler plate #12725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:x/auth
C:x/authz
C:x/capability
C:x/crisis
C:x/distribution
distribution module related
labels
Jul 26, 2022
alexanderbez
approved these changes
Jul 26, 2022
alexanderbez
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a changelog entry for this for sure!
amaury1093
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* remove legacy appmodule boiler plate * remove legacy code * remove legacy gov rest routes * remove staking querier * fix legacy * remove unused test * add upgrading and changelog entry * Update UPGRADING.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * fix tests Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:x/auth
C:x/authz
C:x/bank
C:x/capability
C:x/crisis
C:x/distribution
distribution module related
C:x/evidence
C:x/feegrant
C:x/gov
C:x/group
C:x/mint
C:x/nft
C:x/params
C:x/slashing
C:x/staking
C:x/upgrade
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11863, #11552
cc @alexanderbez @ValarDragon